add a test to compare atmosphere and surface fluxes #1541
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/fluxes-test
branch
from
f125e15 to
c2ff263
Compare
juliasloan25
commented
Nov 5, 2025
| CC.Utilities.half, | ||
| ) | ||
|
|
||
| # Integrated land: compare to net radiation stored in the bucket cache |
There was a problem hiding this comment.
Suggested change
| # Integrated land: compare to net radiation stored in the bucket cache | |
| # Bucket land: compare to net radiation stored in the bucket cache |
szy21
approved these changes
Nov 5, 2025
Comment on lines
+49
to
+50
| # Convention note: bucket R_n is stored with the opposite sign (see climaland_bucket.jl), | ||
| # so we compare atmos_flux ≈ -R_n on land points. |
There was a problem hiding this comment.
Suggested change
| # Convention note: bucket R_n is stored with the opposite sign (see climaland_bucket.jl), | |
| # so we compare atmos_flux ≈ -R_n on land points. | |
| # Convention note: bucket R_n is stored with the same sign (positive upward, see climaland_bucket.jl), | |
| # so we compare atmos_flux ≈ R_n on land points. |
Comment on lines
+9
to
+10
| # - Bucket land: compares against `sim.integrator.p.bucket.R_n` with opposite sign | ||
| # convention (so atmos ≈ -R_n) on land-dominant cells. |
There was a problem hiding this comment.
Suggested change
| # - Bucket land: compares against `sim.integrator.p.bucket.R_n` with opposite sign | |
| # convention (so atmos ≈ -R_n) on land-dominant cells. | |
| # - Bucket land: compares against `sim.integrator.p.bucket.R_n` on land-dominant cells. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #1536
To-do
Content